Fix manual status updates for application URLs - #101
Open
raederhans wants to merge 1 commit into
Open
Conversation
Manual email or out-of-band applications may be recorded with either the discovery URL or the final application URL. Resolve both forms to one canonical job row and stop with an actionable error when the URL is missing or ambiguous, so the CLI never prints success after a zero-row update. Constraint: Keep this independent of browser auto-apply and provider changes. Rejected: UPDATE with url OR application_url | duplicate application URLs could mutate multiple jobs. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Preserve exact-match and ambiguity checks for manual status writes. Tested: pytest tests -q (6 passed); ruff check tests/test_manual_status.py; compileall; diff check Not-tested: Full upstream ruff remains blocked by 149 pre-existing findings on main.
raederhans
marked this pull request as ready for review
August 14, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply --mark-appliedand--mark-failedagainst either the canonical discovery URL or the finalapplication_url[Unreleased]Root cause
The manual status path executed
UPDATE jobs ... WHERE url = ?and ignored the affected-row count. The CLI then printedMarked as appliedorMarked as failedunconditionally. That made out-of-band applications, including email applications, easy to misrecord when the operator had the final ATS/application URL rather than the original discovery URL.User impact
Manual status commands now identify the canonical row before writing. Unknown or ambiguous URLs produce an actionable error and exit code 1, so automation cannot treat a zero-row update as success.
Validation
pytest tests -q- 6 passedruff check tests/test_manual_status.py- passedpython -m compileall -q src tests- passedgit diff --check- passedKnown repository baseline
ruff check srcis not green on the current upstreammain; it reports 149 pre-existing findings across the existing source tree. This PR does not broaden into unrelated lint cleanup.