Skip to content

refactor(codegen): defuse the guarded-wildcard trap in accumulator_rhs_is_numeric #9308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
proggeramlug wants to merge 1 commit into from
Closed

refactor(codegen): defuse the guarded-wildcard trap in accumulator_rhs_is_numeric #9308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions crates/perry-codegen/src/stmt/stable_packed_accumulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,18 @@ fn accumulator_rhs_is_numeric(
// expression lowers to a tag-test diamond over
// `js_dynamic_string_or_number_add` — the same cost #9060 and
// #9091 removed for the bare-counter form.
_ if offset_reads_inlined => {
crate::expr::packed_f64_loop_index_parts(index)
.is_some_and(|(i, _)| i == counter_id)
// Single unguarded catch-all, deliberately. A guarded `_ if flag =>`
// arm here makes any LATER arm unreachable while the flag is true,
// and the compiler cannot warn — reachability depends on the runtime
// guard. #9303's first cut added an index form below exactly such an
// arm and verified as a complete no-op in the range tier while
// passing every flag-false test. New index forms extend the body of
// THIS arm.
_ => {
offset_reads_inlined
&& crate::expr::packed_f64_loop_index_parts(index)
.is_some_and(|(i, _)| i == counter_id)
}
_ => false,
}
}
Expr::LocalGet(id) => {
Expand Down
Loading