Skip to content

fix(runtime): restore Node-API host build after Buffer refactor #9282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 2 commits into from
Aug 31, 2026
Merged

fix(runtime): restore Node-API host build after Buffer refactor #9282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4dc695
fix(runtime): restore Node-API host build after Buffer refactor
Aug 31, 2026
f713bb2
docs(changelog): record Node-API host build fix
Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.d/9282-node-api-host-buffer-brand.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fixed the feature-gated Node-API host build after the Buffer branding refactor.
Allowlisted native addons once again link the complete 145-symbol host ABI and
load their authenticated sidecars instead of falling back to a runtime without
Node-API support.
2 changes: 1 addition & 1 deletion crates/perry-runtime/src/node_api_host/buffers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ pub unsafe extern "C" fn napi_get_buffer_info(
length: *mut usize,
) -> NapiStatus {
let owner = match pointer_owner(env, value) {
Ok(owner) if is_node_buffer(owner) => owner,
Ok(owner) if crate::buffer::is_node_buffer(owner) => owner,
_ => return set_status(env, NapiStatus::InvalidArg, "value must be a Buffer"),
};
let buffer = owner as *const BufferHeader;
Expand Down
Loading