Reduce per-frame allocations: reuse emitter/order and reserve buffers in render state - #2
Merged
TiernanDeFranco merged 1 commit intoMay 7, 2026
Conversation
TiernanDeFranco
deleted the
codex/locate-hot-path-allocations-for-optimization
branch
May 7, 2026 06:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
emitter_order: Vec<usize>field toGpuPointParticles3Dand reuse it across frames instead of allocating a temporaryemitter_ordervector eachpreparecall.self.emitter_orderinprepareand iterate over it when pushing emitters, preserving capacity between frames.Runtime::drain_render_commandsso the pre-allocated scratch capacity can be reused byresource_api::drain_commands.Vec::appendinRenderState::drain_commandsand before appending pending transform roots inDirtyState::take_pending_transform_rootsto avoid intermediate reallocations.Testing
cargo buildto verify no compilation errors, and the build succeeded.cargo testacross affected crates to validate behavior, and the tests passed.Codex Task