Skip to content

fix: clamp PBR roughness at 0.089 - #69

Merged
PenguinMaintainer merged 4 commits into
masterfrom
future/pbr-roughness-floor
Aug 17, 2026
Merged

fix: clamp PBR roughness at 0.089#69
PenguinMaintainer merged 4 commits into
masterfrom
future/pbr-roughness-floor

test: bind roughness contract to constant

d574c0e
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis succeeded Aug 16, 2026 in 0s

Your pull request is up to standards!

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 4
           

Complexity increasing per file
==============================
- Tests/Release/ConsumerProject/Assets/Editor/PureBaseConsumerReleaseTests.cs  3
- Tests/Daily/Editor/PureBaseRenderingModeContractTests.ProductContracts.cs  4
- Tests/Daily/Editor/PureBaseRenderingModeRenderingTests.SourceContracts.cs  2
- Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughness.cs  11
- Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughnessRuntime.cs  8
- Tests/Daily/Editor/PureBaseValidationSceneRegressionTests.PbrRoughness.cs  4
- Tests/Regeneration/Editor/PureBaseRoughnessLightmapBakeTests.cs  43
         

See the complete overview on Codacy

Annotations

Check notice on line 26 in Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughness.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughness.cs#L26

'partial' is gratuitous in this context.

Check notice on line 25 in Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughnessRuntime.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughnessRuntime.cs#L25

'partial' is gratuitous in this context.

Check notice on line 28 in Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughnessRuntime.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Tests/Daily/Editor/PureBaseToonLightingContractTests.PbrRoughnessRuntime.cs#L28

'partial' is gratuitous in this context.

Check notice on line 25 in Tests/Daily/Editor/PureBaseValidationSceneRegressionTests.PbrRoughness.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Tests/Daily/Editor/PureBaseValidationSceneRegressionTests.PbrRoughness.cs#L25

'partial' is gratuitous in this context.