Skip to content

Fix Release Shader-Core host cardinality - #65

Merged
PenguinMaintainer merged 4 commits into
masterfrom
fix/release-validation-shader-core-host-cardinality-fix
Aug 15, 2026
Merged

Fix Release Shader-Core host cardinality#65
PenguinMaintainer merged 4 commits into
masterfrom
fix/release-validation-shader-core-host-cardinality-fix

Conversation

@PenguinDOOM

Copy link
Copy Markdown
Collaborator

Summary

  • Synchronize Release Shader-Core initialization with the canonical 13-host manifest and four product shader rows.
  • Add fail-closed contract coverage for the 17-row bootstrap mapping, including ToonShadow and ToonOpenLitGamma module mappings.
  • Export bootstrap initialization and fixed-point reports in the Release validation artifact, with workflow contracts that require only those filename-specific paths.

Validation

  • Invoke-Pester -Path Tests/Release/Run-PureBaseReleaseValidation.Tests.ps1 — 3 passed, 0 failed.
  • Invoke-Pester -Path .github/tests — 353 passed, 0 failed, 1 skipped.
  • GitHub Actions Automation tests run 31900804848 — success on c26ebdbb4fbf0fcf4df6b1b30c5995013ede409c.
  • GitHub Actions Release validation run 31900806702 — success on the same SHA.
  • Downloaded release artifact verification confirmed both 17-row initialization reports, exact ToonShadow/ToonOpenLitGamma mappings, empty fixed-point and immutable delta arrays, clean repository state, and matching package ZIP SHA-256.

- Add canonical manifest contracts for the 13-host, 17-row Release mapping.
- Seed expected RED coverage for stale consumer and runner profiles.
- Align Release consumer and runner profiles with the 13-host canonical manifest.
- Verify focused contracts, Automation Pester, Regeneration, and isolated Daily validation.
- Require bootstrap and fixed-point reports in the Release artifact contract.
- Preserve existing export assertions and validate the expected RED omission.
- Upload bootstrap and fixed-point reports with Release validation evidence.
- Verify focused and Automation Pester contracts remain green.
@PenguinDOOM
PenguinDOOM requested review from a team and a lite review from Copilot August 15, 2026 19:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Release validation and contract tests to align Shader-Core bootstrap initialization with the canonical manifest cardinality (13 fixed hosts + 4 product shader rows), and ensures the corresponding evidence reports are exported as workflow artifacts.

Changes:

  • Update expected Shader-Core host/mapping counts across Release validation scripts and C# consumer bootstrap (15 → 17 rows; 11 → 13 hosts).
  • Add fail-closed GitHub-side contract coverage to ensure the release bootstrap mappings exactly match the canonical manifest, including ToonShadow and ToonOpenLitGamma module mappings.
  • Extend Release validation artifact upload contracts (and workflow) to include Shader-Core initialization and fixed-point reports.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Tests/Release/Run-PureBaseReleaseValidation.Tests.ps1 Updates Release harness assertions to require 17-row initialization reports and validates ToonShadow/ToonOpenLitGamma mappings; expands evidence upload contract expectations.
Tests/Release/Run-PureBaseReleaseValidation.ps1 Extends the first-bootstrap Shader-Core settings profile with ToonShadow/ToonOpenLitGamma and enforces 17 total canonical rows.
Tests/Release/ConsumerProject/Assets/Editor/PureBaseConsumerReleaseTests.cs Aligns the consumer bootstrap’s manifest validation to the canonical 13-host requirement.
Tests/Regeneration/Editor/ShaderCoreTestStateInitializerTests.cs Updates regeneration test expectations to 17 rows and asserts ToonShadow/ToonOpenLitGamma mappings.
.github/workflows/release-validation.yml Uploads Shader-Core initialization and fixed-point JSON reports as part of the Release validation evidence artifact.
.github/tests/ReleaseShaderCoreBootstrapContracts.Tests.ps1 New GitHub-side contract test that compares release bootstrap profiles and loader output against the canonical manifest (including exact Toon mappings).
.github/tests/HostedUnityReviewContracts.Tests.ps1 Updates expected evidence artifact path list to include the three new JSON reports.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR successfully updates the Shader-Core host cardinality to align with the 13-host manifest and the 17-row bootstrap mapping requirement. The synchronization of initialization logic and constants in the consumer project appears correct, ensuring the system handles the specific module mappings for ToonShadow and ToonOpenLitGamma as intended.

Codacy analysis reports that the changes are up to standards with no new quality issues or complexity increases. The release validation workflows have been properly extended to include initialization and fixed-point reports in the build artifacts. No critical logic bugs or security concerns were identified during the review.

Test suggestions

  • Verify that the total row count in the Shader-Core mapping is exactly 17
  • Verify exact module ID mapping for 'PureBase/Tests/ShaderCore/ToonShadow'
  • Verify exact module ID mapping for 'PureBase/Tests/ShaderCore/ToonOpenLitGamma'
  • Ensure the ExpectedHostCount constant in C# source matches the 13-host manifest cardinality
  • Confirm that artifact upload paths include initialization and fixed-point reports

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@PenguinDOOM PenguinDOOM added this to the 0.2.0 milestone Aug 15, 2026
@PenguinMaintainer
PenguinMaintainer enabled auto-merge (squash) August 15, 2026 20:06
@PenguinMaintainer
PenguinMaintainer merged commit 26cb94a into master Aug 15, 2026
16 checks passed
@PenguinMaintainer
PenguinMaintainer deleted the fix/release-validation-shader-core-host-cardinality-fix branch August 15, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants