Align Toon SH lighting with OpenLit - #64
Your pull request is up to standards!
Here is an overview of what got changed by this pull request:
Issues
======
- Added 7
Complexity increasing per file
==============================
- Tests/Daily/Editor/ShaderCoreTestHostManifestTests.cs 23
- Tests/Daily/Editor/PureBaseToonLightingContractTests.Runtime.cs 2
- Tests/Daily/Editor/PureBaseRenderingModeRenderingTests.OpenLitSourceContracts.cs 5
- Tests/Daily/Editor/PureBaseToonLightingContractTests.LilToonObservation.cs 20
- Tests/Daily/Editor/PureBaseToonLightingContractTests.OpenLit.cs 30
- Tests/Daily/Editor/PureBaseToonLightingContractTests.OpenLitRegression.cs 9
- Tests/Daily/Editor/PureBaseToonLightingContractTests.OpenLitRuntime.cs 1
Complexity decreasing per file
==============================
+ Tests/Daily/Editor/PureBaseToonLightingContractTests.cs -7
See the complete overview on Codacy
Annotations
codacy-production / Codacy Static Code Analysis
Tests/Daily/Editor/PureBaseRenderingModeRenderingTests.OpenLitSourceContracts.cs#L27
'partial' is gratuitous in this context.
codacy-production / Codacy Static Code Analysis
Tests/Daily/Editor/PureBaseToonLightingContractTests.LilToonObservation.cs#L29
'partial' is gratuitous in this context.
codacy-production / Codacy Static Code Analysis
Tests/Daily/Editor/PureBaseToonLightingContractTests.LilToonObservation.cs#L181
'partial' is gratuitous in this context.
Check notice on line 24 in Tests/Daily/Editor/PureBaseToonLightingContractTests.OpenLitRuntime.cs
codacy-production / Codacy Static Code Analysis
Tests/Daily/Editor/PureBaseToonLightingContractTests.OpenLitRuntime.cs#L24
'partial' is gratuitous in this context.
Check notice on line 27 in Tests/Daily/Editor/PureBaseToonLightingContractTests.OpenLitRuntime.cs
codacy-production / Codacy Static Code Analysis
Tests/Daily/Editor/PureBaseToonLightingContractTests.OpenLitRuntime.cs#L27
'partial' is gratuitous in this context.
Check notice on line 153 in Tests/Daily/Editor/PureBaseToonLightingContractTests.Runtime.cs
codacy-production / Codacy Static Code Analysis
Tests/Daily/Editor/PureBaseToonLightingContractTests.Runtime.cs#L153
'partial' is gratuitous in this context.
Check notice on line 357 in Tests/Daily/Editor/ShaderCoreTestHostManifestTests.cs
codacy-production / Codacy Static Code Analysis
Tests/Daily/Editor/ShaderCoreTestHostManifestTests.cs#L357
Method ShaderCoreTestHostManifestTests::HasConfiguredOpenLitRuntimeEvidence has a cyclomatic complexity of 11 (limit is 10)