fix: resolve nested &hexid: placeholders in ST tag resolution#1
Open
barry-heap wants to merge 1 commit into
Open
fix: resolve nested &hexid: placeholders in ST tag resolution#1barry-heap wants to merge 1 commit into
barry-heap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ST tag resolution leaving nested &hexid: placeholders unresolved when a comps name is itself a raw module-address reference — see issue [link once you've filed it, or just paste the report text you already have].
Tested against a real production project: 10 of 59 affected ST routines now resolve correctly (64/64 total after also unlocking some previously source-protected AOIs). Existing test suite passes unchanged (105 passed, 2 skipped, one pre-existing unrelated pytest-asyncio setup error in my environment, confirmed present on unmodified code too).
Diagnosed and fixed with the help of Claude (Anthropic)