Feature/update big int - #23
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RSA implementation to use the operations::BigInt type (and associated submodule/library) in place of the prior Base256 type, aligning the codebase and build system with the updated big-integer dependency.
Changes:
- Replace
operations::Base256withoperations::BigIntacross key structures, key generation, and serialization/deserialization. - Update encryption/decryption to operate on
operations::BigIntvalues. - Update build linkage and docs to reference
BigIntinstead ofBase256.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/keyPair.h | Switch key fields and (de)serialization helpers to operations::BigInt. |
| src/keyPair.cpp | Update key generation and key (de)serialization codepaths to use operations::BigInt. |
| src/helper.h | Update include to the new bigint header dependency. |
| src/encrypt.cpp | Use operations::BigInt for plaintext/ciphertext math. |
| src/decrypt.cpp | Use operations::BigInt for ciphertext/plaintext math. |
| docs/algorithms/div.md | Update normalization wording from Base256 to BigInt. |
| CMakeLists.txt | Link RSA target against BigInt rather than Base256. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update submodule and references to it.
Issue ticket number if there is one