Fix: пустая Side Panel у Chrome-расширения YouTube - #2
Open
PaperPit wants to merge 3 commits into
Open
Conversation
Load sidepanel.js as a classic IIFE next to the HTML, keep video state in chrome.storage.local, and surface boot errors in the panel instead of failing silently before the first paint. Co-authored-by: PaperPit <PaperPit@users.noreply.github.com>
Object.entries(null) threw before first paint; coerce attrs to {}.
Co-authored-by: PaperPit <PaperPit@users.noreply.github.com>
Removes remaining el(tag, null, ...) call sites that crashed Object.entries before first paint when an older build was still loaded. Co-authored-by: PaperPit <PaperPit@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
Side Panel открывалась, но оставалась пустой: скрипт либо не грузился как ES module из
../dist/, либо падал до первого рендера (в т.ч. из‑заchrome.storage.session).Исправление:
sidepanel.jsсобирается как IIFE рядом с HTML (extension/sidepanel/sidepanel.js)chrome.storage.local1.0.1Связанный Issue
нет (регрессия после #1)
Test plan
npm run ext:buildЧеклист