Remove redundant casts - #231
Open
FranciscoTGouveia wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes redundant as usize casts when adding the result of read_integer(...) to literal_length and match_length during safe block decompression. This aligns the call sites with read_integer’s existing return type (Result<usize, DecompressError>), keeping the decompression logic unchanged while simplifying the code.
Changes:
- Removed
as usizecasts afterread_integer(input, &mut input_pos)?when updatingliteral_length. - Removed
as usizecasts afterread_integer(input, &mut input_pos)?when updatingmatch_length.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe these casts can be safely removed, as the source type is already the target type.
For reference, these changes were found by an optimizer developed as a research project.
CC @nunoplopes