Fix bugs in interpolation constraints module - #892
Open
maxbriel wants to merge 1 commit into
Open
Conversation
- correct_sum: rescale with the resolved 'target' instead of the raw 'constraint' value, which raised a TypeError when the constraint was given as a string fieldname. - check_order_of_constraints: access constraint dict fields via [] (was broken attribute access), fix the 'upate' -> 'update' typo that raised AttributeError, and handle type-2/type-3 constraints so the function actually runs and reports ordering issues.
sgossage
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correct_sum: rescale with the resolved 'target' instead of the raw 'constraint' value, which raised a TypeError when the constraint was given as a string fieldname. This mostly works because target is often equal to a float and then
targe = constraint.check_order_of_constraints: access constraint dict fields via [] (was broken attribute access), fix the 'upate' -> 'update' typo that raised AttributeError, and handle type-2/type-3 constraints so the function actually runs and reports ordering issues. Function is not really used, but this allows it to handle the other constraint types.