[enhancement] Multithreaded Zenodo downloads - #883
Draft
sgossage wants to merge 5 commits into
Draft
Conversation
for more information, see https://pre-commit.ci
sgossage
changed the title
sgossage
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a multithreaded download scheme for retrieving our data from Zenodo.
It hopefully speeds things up. Zenodo apparently limits the download speed per connection. This downloads files in chunks via multiple threads, each which their own connection (by default 8 threads, going hire seems to be counterproductive).
I've seen about 3x speed up from this.
Also adds another warning before attempting to download missing interpolator files to say which file was missing.