[enhancement] Update default parameters - #868
Open
maxbriel wants to merge 536 commits into
Open
Conversation
for more information, see https://pre-commit.ci
[v2.3] Pass RNG to evolution steps
for more information, see https://pre-commit.ci
…ON into sg_v2.3_gpaths_in_ini
for more information, see https://pre-commit.ci
…ON into sg_v2.3_gpaths_in_ini
for more information, see https://pre-commit.ci
… existence check because it breaks the unit tests
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ridutils._get_grid_column
for more information, see https://pre-commit.ci
…ode/POSYDON into mb_post_processing_fix
for more information, see https://pre-commit.ci
…ode/POSYDON into mb_post_processing_fix
for more information, see https://pre-commit.ci
[fix/enhancement] move SN_models out of `final_values`
…ich missing file triggered it for easier debugging.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Remove `self.binary` calls in `collapse_star`
Warn before downloading data
[feat] CO Peters equation integration variable change
fix: prevent internal save in plot_popsyn_over_grid_slice when save_fig=False
Changed orbital_period_scheme from 'Sana+12_period_extended' to 'power_law' and added power_law_slope parameter.
Contributor
|
We should be sure to change the target branch to main, from v2.3. This looks fine to me otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the defaults of the population synthesis file to:
The change in period distribution is based on Sana et al. (2025)), see the excerpt below.
Note that the boundaries of this study run from 1 day to$10^{3.5}$ days and found $76\pm8%$ of O stars in the SMC are in binaries with $P<10^3.5$ days (~3'162 days). The current default period boundaries or binary fraction are not made consistent with this!