fix(deps): resolve all high-severity Dependabot alerts - #82
Merged
Conversation
… Dependabot alerts Resolves GitHub Dependabot alerts #107-#112 (axios prototype pollution, SSRF, ReDoS, credential leaks; -> 1.20.0), #117 (form-data CRLF injection; -> 4.0.6), and #120 (hono CORS credential reflection; -> 4.13.7). Lockfile-only change; no package.json ranges needed updating. Verified with bun install/test/build.
mcp-server: bump @modelcontextprotocol/sdk (1.25.3 -> 1.30.0), fast-uri (-> 3.1.7), and migrate express 4 -> 5.2.1 (its transitive path-to-regexp 0.1.x is permanently vulnerable on the 4.x line; no upstream 4.x patch exists). The app only serves 3 literal routes (/health, /mcp GET/POST/DELETE) with no dynamic path params, so the migration needed no code changes. Verified with bun test (73/73 passing), a sidecar build, and a manual smoke test of all three routes. agent-monitor: bump axios (-> 1.20.0), form-data (-> 4.0.6), ws (8.18.3 -> 8.21.3, nested @microsoft/signalr copy 7.5.10 -> 7.5.13), and jws (-> 3.2.3). Lockfile-only; package.json ranges already covered these versions. Together with the prior commit (axios/hono/form-data in mcp-server), this closes 39 of the 41 open high-severity alerts on github.com/PMTLabs/termflow-core/security/dependabot. The one remaining moderate finding (ajv, pulled in by @modelcontextprotocol/sdk) has no available fix upstream yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 41 open high-severity Dependabot alerts (https://github.com/PMTLabs/termflow-core/security/dependabot), across two lockfiles:
mcp-server/package-lock.json
1.13.2 -> 1.20.0(prototype pollution, SSRF, ReDoS, proxy-credential leaks — #107-#112)4.0.5 -> 4.0.6(CRLF injection — #117)4.11.5 -> 4.13.7(CORS reflects Origin with credentials — #120, fix(tabs): stop a tab drag freezing the app on macOS #69)1.19.9 -> 2.1.1(feat(automations): the terminal menu's automations open on hover, like snippets #72) — bump follows@modelcontextprotocol/sdk's own declared support range (^1.19.9 || ^2.0.5)1.25.3 -> 1.30.0(fix(activity): announce PTY resizes from the bridge so canvas zoom stops notifying #64)3.1.0 -> 3.1.7(Ended-region tint: survive a column widen (Path B logical-line re-anchor) #8,Peer-pairing UI + fabric backend, and a dev-only build badge #9,Ctrl+Delete word-forward-delete parity with Ctrl+Backspace #20,fix(reattach): inherit persisted cwd for a split pane when the live query is blind #23,fix(reattach): re-seed command-suggest prompt gate on reload AND hot-swap #24,feat(command-suggest): seed the prompt gate ARMED when a reattached session sits at a bare prompt #26,fix(terminal-core): cache-lifetime protocol state (backlog 003) + ED3 resize-wipe auto-repair #27)4.22.1 -> 5.2.1+ path-to-regexp-> 8.4.0(Automations: fix command matching, and four editor/menu UX gaps #74, fix(canvas): keep the world supersample off the terminal it would halve #75) — Express 4's bundled path-to-regexp (0.1.x) has no further upstream patch; the fix lives only in Express 5's rewritten router. The app exposes 3 literal routes (/health,/mcpGET/POST/DELETE) with no dynamic path params, so no code changes were needed.agent-monitor/package-lock.json
1.10.0 -> 1.20.0(Notification click routing on macOS and Linux (and never steal focus) #28,fix(terminal-core): preserve cache fields dropped on every remount #31,Canvas Mode phases A-C: pure geometry, canvas slice, and the mode toggle #36,ci: widen the e2e setup-bun guard to cover the Linux self-hosted runners #38,Restore every window, not just one: per-window sessions + a window registry #41,perf(terminal): stop the ended-tint re-measuring once per row per frame, and gate the per-chunk PTY log #42,fix: three keyboard-ownership bugs — canvas keys, Ctrl+W rebinding, and the reattach seed #51-Canvas: node menu, copy link, sidebar zoom, reading-order Tab, overlay group chip #56)4.0.4 -> 4.0.6(Settings: host in main window, sync changes live across windows #59)8.18.3 -> 8.21.3, nested@microsoft/signalrcopy7.5.10 -> 7.5.13(fix(canvas): group label drifts off the border as you zoom in #57, Add Settings controls for terminal font weight #58)3.2.2 -> 3.2.3(fix: restore Ctrl+C interrupts for host-owned shells #29)All changes are dependency bumps within (or, for express/@hono-node-server, just above) the existing
package.jsonsemver ranges. No application code changed except theexpressversion pin itself.One moderate-severity finding remains (
ajv, pulled in transitively by@modelcontextprotocol/sdk) — no fixed version is available upstream yet.Test plan
bun testinmcp-server— 73/73 passing (both before and after the Express 5 migration)bun build --compilesidecar build succeedsmcp-serverunder Express 5:GET /health(200),POST /mcpwithout session (400, expected error shape),DELETE /mcpon unknown session (404, expectedSession not found)tsc --noEmitclean inmcp-server(pre-existing unrelatedbun:testtype errors in one test file, verified present before this change too)npm auditin bothmcp-serverandagent-monitorshows 0 high-severity findings after the bumpagent-monitorhas no test suite (pre-existing); it also has pre-existing unrelatedtscerrors in several files, verified present before this change and untouched by it