fix(automation): keep a wrapped problem's bullet on its first line - #81
Merged
Merged
Conversation
Reported: the bullet for `Send to terminal — Add a terminal message or a webhook destination.` drew beside `webhook destination.`, with the words it belonged to sitting above it unmarked. A `<button>` is `inline-block`, and an inline-block's baseline is the baseline of its LAST line box. A problem long enough to wrap therefore gave its `li` a single line box whose baseline sat on the second line, and an outside list marker is placed on that baseline. The one-line problem above it had no symptom, which is why only one of the two looked wrong. Block-level, so the button's first line IS the item's first line and the marker has nowhere else to go. Full width is a bonus: the whole row becomes the click target for the step it focuses. Third instance of one family this week - `Re-arm now` riding high against its pill, the info icon sitting low against its label, and now this - all inline-level boxes aligned on a baseline that is not where it looks. jsdom cannot lay this out, so it was checked by rendering the stylesheet's own `.au-problems` rules in headless Edge, before and after, at a width that forces the wrap. The test asserts the declaration that makes it true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported against the running build: the bullet for
Send to terminal — Add a terminal message or a webhook destination.drew besidewebhook destination., with the words it belonged to sitting above it unmarked.Cause
A
<button>isinline-block, and an inline-block's baseline is the baseline of its LAST line box. A problem long enough to wrap gave itslia single line box whose baseline sat on the second line, and an outside list marker is placed on that baseline. The one-line problem above it had no symptom, which is why only one of the two looked wrong.display: blockmakes the button's first line the item's first line, so the marker has nowhere else to go. Full width is a bonus rather than a cost — the whole row becomes the click target for the step it focuses.Third instance of one family
Re-arm nowriding high against its state pill, the ⓘ sitting low against its field label, and now this: all inline-level boxes aligned on a baseline that is not where it looks. The first two were fixed in #80 with flex rows; this one is a list marker, so the answer is to stop the button being inline-level at all.How it was checked
jsdom does not lay out, so a
displayassertion alone would be a restatement. The fix was verified by extracting the stylesheet's own.au-problemsrules and rendering them in headless Edge — before and after, at a width that forces the wrap — which reproduced the reported bullet exactly and then showed it corrected. The test asserts the declaration that makes it true, and dies if the button goes back to inline-block.Gates
No Rust touched.