tas_log fixes - #479
Conversation
…not working on Portal 3420
|
I feel like it's incorrect to read m_vecAbsOrigin from playerio around ProcessMovement (especially on the Post callback). Between SetupMove and FinishMove, the move data object and the player data can desync (it's only on FinishMove that it gets copied from mv into the player, and the only thing that seems to happen between Setup and Finish is ProcessMovement), so I'd expect the Post callback logs to show no change if you read from playerio. Even from a micro-optimization perspective, I don't think the calls to the inline CMoveData::GetAbsOrigin would cause issues (you gotta deref 3 different floats anyway and they all happen next to each other in code). |
No description provided.