Skip to content

tas_log fixes - #479

Open
lipsanen wants to merge 1 commit into
OutOfBoundsOffice:masterfrom
lipsanen:tas_logging
Open

tas_log fixes#479
lipsanen wants to merge 1 commit into
OutOfBoundsOffice:masterfrom
lipsanen:tas_logging

Conversation

@lipsanen

Copy link
Copy Markdown
Collaborator

No description provided.

@SirWillian

SirWillian commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

I feel like it's incorrect to read m_vecAbsOrigin from playerio around ProcessMovement (especially on the Post callback). Between SetupMove and FinishMove, the move data object and the player data can desync (it's only on FinishMove that it gets copied from mv into the player, and the only thing that seems to happen between Setup and Finish is ProcessMovement), so I'd expect the Post callback logs to show no change if you read from playerio. Even from a micro-optimization perspective, I don't think the calls to the inline CMoveData::GetAbsOrigin would cause issues (you gotta deref 3 different floats anyway and they all happen next to each other in code).
I see that you made the change to fix an issue on 3420, but at least following the general flow of the code it doesn't seem entirely right to do it for all games.
In what way was it broken in 3420? Based on the Source 2003 leak, my guess is that the origin member moved in CMoveData at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants