Refactor NamespacedIdentifier#identifier -> NamespacedIdentifier#path - #83
Open
lowercasebtw wants to merge 1 commit into
Open
Refactor NamespacedIdentifier#identifier -> NamespacedIdentifier#path#83lowercasebtw wants to merge 1 commit into
lowercasebtw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reasoning behind this is that a Identifier does not hold a child "identifier", and every other impl from Modern to other things name it the "path" of the Identifier. calling
identifier.identifiermakes 0 sense.I also moved the vanilla namespace constant to NamespacedIdentifier as I think it belongs there instead for more convinent access as thats where people would think to look for it at, as before I did not know it existed elsewhere.
I have left a
@Deprecatedimplementation ofidentifierthat redirects to path, so that peoples projects will continue to work for the time being.I also fixed some variable names and tried to tidy it up a bit to be more readable, alongside making the comparator use Comparator chaining.