Skip to content

feat: Introduce remove_cache_files option to file listing - #245

Merged
alexiswl merged 2 commits into
mainfrom
bugfix/improve-get-files-from-portal-run-id-function
Jun 4, 2026
Merged

feat: Introduce remove_cache_files option to file listing#245
alexiswl merged 2 commits into
mainfrom
bugfix/improve-get-files-from-portal-run-id-function

Conversation

@alexiswl

@alexiswl alexiswl commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@alexiswl alexiswl self-assigned this Jun 4, 2026
Copilot AI review requested due to automatic review settings June 4, 2026 00:46
@alexiswl alexiswl added the bug Something isn't working label Jun 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new remove_cache_files option to list_files_from_portal_run_id() to allow callers to control whether cache objects are filtered out when listing files for a given portal_run_id.

Changes:

  • Added remove_cache_files parameter to list_files_from_portal_run_id() and refactored filtering to make log and cache filtering independently toggleable.
  • Simplified list_output_files_from_portal_run_id() to delegate filtering to list_files_from_portal_run_id() rather than applying an extra substring filter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Fix indentation and readability
Use '/' prefix on cache and logs regexes to prevent removing valid analysis outputs
@alexiswl
alexiswl added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit 891e381 Jun 4, 2026
5 checks passed
@alexiswl
alexiswl deleted the bugfix/improve-get-files-from-portal-run-id-function branch June 4, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants