fix(db): normalize asyncpg database URLs to sync psycopg dialect - #45
Merged
Conversation
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Summary
This PR resolves issue #44 by adding automatic URL scheme normalization in
flow.store.db.normalize_db_url()when creating synchronousSQLModelengines.Problem
When
FLOW_DATABASE_URLis set to an async PostgreSQL dialect URL (postgresql+asyncpg://...),SQLAlchemy's synchronous engine fallback fails to automatically check in connection objects whenwith get_session(engine) as s:context blocks exit. This causes connection leaks and outputs Python GC warnings:Changes
normalize_db_url(url)tofile:///home/stano/flow/src/flow/store/db.pyto rewritepostgresql+asyncpg://andpostgres+asyncpg://schemes topostgresql+psycopg://.make_engine()to normalize the database URL before initializing the engine.file:///home/stano/flow/tests/test_db.pycovering SQLite, psycopg, asyncpg normalization, and engine creation calls.Testing
uv run ruff checkpassed with zero lints.uv run pytestpassed all 47 tests (including 4 new tests intest_db.py).