fix(persona): the lines go behind the boxes, and one thing looks pressed - #203
Merged
Conversation
Three things a person testing the map reported, in the order they hit them. **The edges were drawn over the cards.** The SVG is positioned and the bands were not, so it won a stacking contest nobody entered it into: every curve ran across the boxes it connects, through the type and the value. The bands are positioned now with a higher `zIndex`, and an edge that disappears under a card reads as going behind it — which is what it does. **Everything a selection reached looked selected.** Both the pressed card and the ones it reaches wore a coloured border, so clicking a persona outlined its face, its attributes and its context in the same treatment as the row that was clicked: a dozen outlined boxes and no way to tell which one was the question. "I clicked on the persona DID — but how can you tell?" The two states stop competing. A reached card is a wash with the ordinary border; only the selection carries a ring, drawn as a hairline of the page's own ground and then the accent so it lifts off a band that is already tinted. One outline on the screen, and it is always the thing you pressed. The persona row inside a context gets the same rule — it is the one people click most, being where "who am I here" is asked. **A withheld value lost its own sentence.** "Singapore · with your agent" does not fit a 222px card and truncated to "Singapore · with y…", dropping the half that says what to do about it. The label steps aside while the value is absent: it is the holder's own note, the type above already names the attribute, and on a card holding nothing the sentence that matters is the one about where the value is. It returns the moment the value does. 367 extension tests pass; `tsc -b` and `npm run build` clean. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
stormer78
force-pushed
the
fix/persona-map-legibility
branch
from
September 8, 2026 16:19
531f27a to
654b55f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things from a live testing pass, in the order they were hit.
The edges were drawn over the cards
The SVG is positioned and the bands were not, so it won a stacking contest nobody entered it into: every curve ran across the boxes it connects, through the type and the value. The bands are positioned now with a higher
zIndex.An edge that disappears under a card reads as going behind it, which is what it does.
Everything a selection reached looked selected
Both the pressed card and everything it reached wore a coloured border, so clicking one persona outlined its face, three attributes, its context and the context's row in the same treatment. A dozen outlined boxes and no way to tell which one was the question.
The two states stop competing:
One outline on the screen, and it is always the thing you pressed. The ring is two-stage so it lifts off a band that is already tinted, where a single soft halo disappears. The persona row inside a context gets the same rule — it is the one people click most, being where who am I here is asked.
A withheld value lost its own sentence
Singapore · with your agentdoes not fit a 222px card and truncated toSingapore · with y…— dropping the half that says what to do about it.The label steps aside while the value is absent. It is the holder's own note, the type above already names the attribute, and on a card holding nothing the sentence that matters is the one about where the value is. It returns the moment the value does.
Checks
367 extension tests pass;
tsc -bandnpm run buildclean.220560e feat(core): a rooms API for the consolewas committed straight to main and leavespackage.module-boundariesandtask-surfacered — see the comment below.