fix(persona): Show asks the agent for the value, because it was never sent one

[stormer78]

Pressing Show on an attribute said not requested. It was telling the truth, and everything around it was not.

What was happening

persona/attribute/list answers a values request with the metadata of every attribute resolving to sensitivity: high and the plaintext of none, unless the caller also sets includeSensitive. The console never set it — the member landed in trust-tasks 0.17.4 and the client was never given it.

So the pane held no value for profile.github, employer, phone.mobile, or anything else the registry treats as sensitive. And it masked the placeholder standing in for the absent value:

on screen	what it meant	what was true
GitHub · •••• + Show	a value, kept off your screen	no value had arrived
Show → not requested	—	the only honest thing on the card
"Your agent has already sent this value here."	reassurance	the one thing that had not happened

Two states wearing one shape, and the reassuring reading was the wrong one.

What it does now

The specification is blunt about which half of sensitivity matters:

A consumer that masks a value it has already received defends a screen; it does not keep a card number out of a log, a crash dump or a process's memory. Ignoring this member and masking client-side is a conforming implementation of nothing.

• includeSensitive reaches the wire. AttributeListParams.includeSensitive in @openvtc/pnm-core/admin, passed through to the payload.
• The pane still lists without it, so the plaintext genuinely is not in the page — and Show becomes the request. manager/reveal-value.ts asks for one attribute, narrowed by typePrefix to its own type and matched back by attributeId: there is no attribute/get in the vocabulary, and a type can have siblings, so position would show the holder the wrong value with no sign anything was wrong.
• Hide drops what was fetched rather than covering it over. A mask over a value still in the tree is the decorative version this path exists to stop being.
• A withheld value is never masked. It reads not on this page, and the strip's explanation splits into the two sentences it always needed — one for a value that is here and covered, one for a value that is not here at all.
• The shortcut is refused, in writing. includeSensitive on the pane's own listing is three lines, makes every Show instant, and puts every card and passport number the holder owns into a React tree because one button might be pressed. reveal-value.ts's header says so, so it is not "fixed" back.

Notes corrected in passing

All three were true when written and had gone stale:

• CLAUDE.md and claim-sensitivity.ts's header both said the read-path control "does not exist yet". It exists, and this PR is the console using it.
• The same paragraph said there is "deliberately no prefix walk". The walk landed in trust-tasks#377 and only ever tightens — payment.giftCard inherits payment's gating, name.somethingNew does not inherit name's none.
• The vocabulary paragraph still said the on-screen word is fact, which docs(persona): the on-screen word for an attribute is "attribute", not "fact" #191 changed and fix(persona): one predicate for what a context is, and colour that says which way a copy went #192 built on, leaving the section contradicting itself.

Checks

• 11 new tests. Extension 339 pass, core 549 pass.
• tsc -b clean across workspaces; npm run build clean, manager.js a single chunk.
• The reveal path is pinned on both sides: the request carries includeValues and includeSensitive and is narrowed to one type; the answer is matched by id; a still-withheld value and a stale credential are two different sentences. The four render tests drive the real pane — withheld reads as missing, Show fetches exactly one attribute, Hide drops it, and a value the agent did send still covers locally without asking again.

Not in this PR

There is still no way to change an attribute's visibility from the console. The wire supports it — sensitivity and release are per-attribute overrides on attribute/put, and absent means "resolve from the registry" — but the attribute editor exposes neither, so profile.github and employer are masked because they are unregistered types and there is no way to say otherwise. That is a separate change to the editor.

[affinidi-appsecurity-bot]

🛡️ AI Agentic Security Code Review

🔎 A manual security review is recommended before merging. Please contact the Security team for specifics and remediation guidance.

ℹ️ Detailed findings are not published on public repositories; the Security team holds the complete report.