docs(follow-ups): record the second escalation include_sensitive now needs - #287
Merged
Conversation
…needs #286 took vta-sdk 0.34, which gave `persona_attribute_list` an `include_sensitive` argument — the read-path control `claim_types`'s module header had been recording as missing. `pool::list` passes `include_values` through to both arguments, so behaviour is unchanged and the distinction is not yet honoured. The reason that is not simply an oversight to fix with a `false` is worth having written down where the work is scheduled rather than only in a code comment: the pane has one escalation and the control needs two. `show_values` both asks the agent for values and reveals masked ones whole, so a listing that asked for values but not for sensitive ones would make a mobile or a card number come back valueless and render as "(no value)" under a reveal — indistinguishable from holding nothing, which is the confusion `masked_is_not_the_same_state_as_absent` exists to name. Kept out of #286 because a tracker change does not belong in a code diff. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One entry in
tasks/follow-ups.md, split out of #286 because a tracker change does not belong in a code diff.#286 took vta-sdk 0.34, which gave
persona_attribute_listaninclude_sensitiveargument — the read-path control thatclaim_types's module header had been recording, correctly, as missing.pool::listpassesinclude_valuesthrough to both arguments, so behaviour is unchanged and the distinction is not yet honoured.The reason that is not simply an oversight to close with a
falseis the whole of the remaining work, and it is worth having written down where work gets scheduled rather than only in a code comment:The shape that works is the one
salready has: list without sensitive values, and let the per-attribute reveal fetch that one value on its own. Then the default read stops carrying every card number into the process's memory and the reveal stays truthful. It needs a single-attribute read path behind theskey.Docs only — no code, no gate beyond the existing markdown.