refactor(persona): the copy outside the pane speaks the vocabulary too - #281
Merged
Conversation
#280 brought the identity pane to `design-docs/persona-vocabulary.md` and left the persona copy elsewhere for when it was next touched. This is that copy: the join flow's identity choice, its reuse warning, the invitation list, and the communities panel's empty state. The reuse warning is the one that matters. It is the last thing a person reads before linking themselves across two communities, and it now carries the sentence the table asks every surface to share verbatim — "the same person to anyone who sees both" — rather than a paraphrase of it. The point of a fixed phrase is that meeting it twice teaches it; a paraphrase in one surface spends the recognition and gives nothing back. ## What was deliberately left alone `profile` in setup, backup and `--profile`. That is the **config profile** — a local installation profile that predates the persona family, has its own meaning to operators, and appears in flags they type. It is exactly the collision the vocabulary doc cites when it declines to use "profile" for a face, and renaming it here would create the confusion the table exists to prevent. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of three PRs bringing the persona vocabulary into sync across the stack:
pnm persona …#280 brought the pane over and left the rest for "when next touched".
What changed
The join flow's identity choice — "Who should this community know you as?",
"Choose the persona this community will know you as", "Already known to:",
"Be someone new to this community" — the invitation list, and the communities
panel's empty state.
The reuse warning is the one that matters. It is the last thing a person
reads before linking themselves across two communities, and it now carries the
table's sentence verbatim:
The point of a fixed phrase is that meeting it twice teaches it. A paraphrase in
one surface spends the recognition and gives nothing back.
What I deliberately left alone
profilein setup, backup and--profile. That is the config profile — alocal installation profile that predates the persona family, has its own meaning
to operators, and appears in a flag they type. It is exactly the collision the
vocabulary doc cites when it declines to use "profile" for a face; renaming it
here would manufacture the confusion the table exists to prevent.
Pre-merge checklist (vti-stack-development-guide §9)
cargo test --workspacegreen (426 in the binary); clippy-D warningsclean.