refactor(vgi-bench): address review feedback from subtree sync - #33
Merged
Conversation
- Un-export VGI_BENCH_DATASET_PATH, VGI_BENCH_TEMPERATURE, makeVgiBenchDatasetLayer, and vgiBenchSolver (never imported externally) - Fix test name: 'lowercase letters' -> the snapshot has uppercase letters - Remove duplicate downscaledVideoUrl test (identical input/output) - Merge five fragmented vgiBenchRecordToSample tests into a single test with an inline snapshot of the full sample plus canary-absence checks
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
bjoerndanz
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the review feedback from the vendored subtree sync PR (openrouter-web#34180). Since
packages/bench-harnessis a vendored subtree, these fixes must land upstream here and will propagate on the next sync.Changes
Un-export unused symbols (fallow audit):
VGI_BENCH_DATASET_PATH,VGI_BENCH_TEMPERATURE,makeVgiBenchDatasetLayer, andvgiBenchSolverwere exported but never imported by other modules. Removed theexportkeyword.Fix test name (Devin review #1):
A) B) C) D)).Remove duplicate test (Devin review #2):
Merge fragmented tests (Devin review #3):
vgiBenchRecordToSample(VGI_RECORD, 0)into a single test with an inline snapshot of the full sample, plus canary-absence assertions.Validation