fix(search): resolve server-tool generation ids - #32
Open
ayush-or wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why search parquet IDs pointed at zero-usage rows
Server-tool search returns a client-visible orchestration generation while its recursive child generations carry model usage. The benchmark collector persisted that root ID, so downstream analysis treated a zero-usage wrapper as the evaluated model call.
TL;DR
Mark server-tool search responses for relation expansion and extend the existing generation resolver to replace wrapper/cache IDs with their underlying leaf generation IDs. Plugin search and non-search callers keep their existing IDs, and failed resolution falls back to the original ID.
What changed
generation_idsresult contract and parquet schema.Sequencing
The OpenRouter monorepo PR will add the authenticated
include_related=truegeneration projection and sync this subtree commit. Without that endpoint projection, resolution safely retains the root ID.Validation
bun run check,bun run typecheck, andbun run buildpassed.bun run verifypassed in the monorepo checkout.Reviewer focus