Validate .language subfield of IPP attributes#1653
Open
nmuggli wants to merge 2 commits into
Open
Conversation
ippValidateAttribute will validate strings, but it doesn't validate the string.language subfield of IPP_TAG_TEXTLANG or IPP_TAG_NAMELANG. Add a helper method to validate these values using the same validation that is currently used for IPP_TAG_LANGUAGE. Added some tests as well.
Contributor
Author
|
Since this isn't a clean cherry-pick into 2.4.x, I also created #1654. I'm not sure how you like to handle merges into 2.4.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ippValidateAttribute will validate strings, but it doesn't validate the string.language subfield of IPP_TAG_TEXTLANG or IPP_TAG_NAMELANG. Add a helper method to validate these values using the same validation that is currently used for IPP_TAG_LANGUAGE.
Added some tests as well.