Skip to content

Show premium membership requirements in game details - #751

Merged
Kief5555 merged 2 commits into
devfrom
capy/premium-membership-game-details
Aug 14, 2026
Merged

Show premium membership requirements in game details#751
Kief5555 merged 2 commits into
devfrom
capy/premium-membership-game-details

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Summary

  • show a localized premium-membership warning in desktop game details when NVIDIA catalog metadata names a recognized paid tier
  • mirror the requirement as a badge and explanatory note in controller-mode game details
  • leave free, missing, and unrecognized metadata unlabeled so OpenNOW does not assert a restriction it cannot verify
  • cover paid-tier detection and conservative unknown handling with automated tests

Requested by Discord user <@1499781612026728504> (lostt).

Metadata behavior

The existing catalog pipeline already requests NVIDIA's gfn.minimumMembershipTierLabel and maps it to GameInfo.membershipTierLabel. This change treats labels containing known paid GFN tier names (Founders, Priority, Performance, Premium, or Ultimate) as explicit paid requirements. Empty, Free, and unknown labels remain silent because the API does not provide a separate boolean entitlement flag and labels may vary by alliance or region.

Visual proof

The screenshots use the real app-details component in the running Electron renderer with representative Forza Horizon 6 metadata. The first supplies minimumMembershipTierLabel: "Performance"; the comparison omits requirement metadata to verify that no warning appears.

Paid requirement present

Forza Horizon 6 details showing the premium membership warning

Requirement metadata unknown

Forza Horizon 6 details without a premium warning when metadata is unknown

Verification

  • npm --prefix opennow-stable test — 604 passed
  • npm --prefix opennow-stable run typecheck
  • npm --prefix opennow-stable run lint — 0 warnings, 0 errors
  • npm --prefix opennow-stable run build
  • npm --prefix opennow-stable run locales:check
  • launched the Electron app and rendered both requirement-present and metadata-unknown details states for the screenshots above

@cursor

cursor Bot commented Aug 13, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fb7cdff7-7def-47c5-8c8d-ae38c6884eb2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kief5555
Kief5555 merged commit 4db0cdd into dev Aug 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants