Show premium membership requirements in game details - #751
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Requested by Discord user <@1499781612026728504> (lostt).
Metadata behavior
The existing catalog pipeline already requests NVIDIA's
gfn.minimumMembershipTierLabeland maps it toGameInfo.membershipTierLabel. This change treats labels containing known paid GFN tier names (Founders,Priority,Performance,Premium, orUltimate) as explicit paid requirements. Empty,Free, and unknown labels remain silent because the API does not provide a separate boolean entitlement flag and labels may vary by alliance or region.Visual proof
The screenshots use the real app-details component in the running Electron renderer with representative Forza Horizon 6 metadata. The first supplies
minimumMembershipTierLabel: "Performance"; the comparison omits requirement metadata to verify that no warning appears.Paid requirement present
Requirement metadata unknown
Verification
npm --prefix opennow-stable test— 604 passednpm --prefix opennow-stable run typechecknpm --prefix opennow-stable run lint— 0 warnings, 0 errorsnpm --prefix opennow-stable run buildnpm --prefix opennow-stable run locales:check