Add TypeScript definition file to package.json - #187
Open
ecstrema wants to merge 1 commit into
Open
Conversation
Currently, when using the 0.0.55 with typescript 7, I get the following error: ``` Could not find a declaration file for module '@openbeta/sandbag'. 'C:/Users/remim/prog/climbhub/node_modules/.bun/@OpenBeta+sandbag@0.0.55/node_modules/@openbeta/sandbag/dist/sandbag.esm.js' implicitly has an 'any' type. There are types at 'C:/Users/remim/prog/climbhub/node_modules/.bun/@OpenBeta+sandbag@0.0.55/node_modules/@openbeta/sandbag/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@openbeta/sandbag' library may need to update its package.json or typings.ts(7016) ``` It seems that although referenced by the "types" field, they are not exported, so typescript 7 refuses to use them. Adding "types" to export fixes it.
Coverage reportCaution Multiple errors occurred
Report generated by 🧪jest coverage report action from a228238 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when using the 0.0.55 with typescript 7, I get the following error:
It seems that although referenced by the "types" field, they are not exported, so typescript 7 refuses to use them.
Adding "types" to export fixes it.