rpmsg: Fix macro parameter mismatch and dead bool return type - #698
Open
cshilwant wants to merge 2 commits into
Open
rpmsg: Fix macro parameter mismatch and dead bool return type#698cshilwant wants to merge 2 commits into
cshilwant wants to merge 2 commits into
Conversation
The macro body references 'rp_hdr' instead of using the declared parameter 'rphdr'. This causes the macro to ignore its argument and always reference whatever 'rp_hdr' variable exists in the calling scope. Fix by using the parameter name in the macro body. Fixes: commit b32187e ("openamp: change rx/tx buffer hold flag to count") Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
The function unconditionally returns true and neither call site checks the return value. Remove the dead return and change the return type to void. Fixes: commit b32187e ("openamp: change rx/tx buffer hold flag to count") Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
arnopo
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.