Skip to content

Add compatibility for SMW 7 - #117

Open
JimmyvanDelft wants to merge 3 commits into
Open-CSP:REL1_43from
JimmyvanDelft:smw-7-compatibility
Open

Add compatibility for SMW 7#117
JimmyvanDelft wants to merge 3 commits into
Open-CSP:REL1_43from
JimmyvanDelft:smw-7-compatibility

Conversation

@JimmyvanDelft

Copy link
Copy Markdown
Collaborator

Fixes form submissions on SMW 7, where ServicesFactory::newTitleFactory() was removed.
Uses SMW’s cross-version MaintenanceFactory instead, preserving compatibility with both SMW 6 and 7 on MediaWiki 1.43.

Info: I had a customer recently updated to SMW 7.2 and now almost all (if not all) flexform submissions fail because:

[exception] [357eed6dd20871e3da2307d7] /Speciaal:FlexForm
Error: Call to undefined method SMW\Services\ServicesFactory::newTitleFactory()

#16 /var/www/html/includes/exception/MWExceptionRenderer.php(190): MediaWiki\Output\OutputPage->output()
#17 /var/www/html/includes/exception/MWExceptionRenderer.php(109): MWExceptionRenderer::reportHTML(Error)
#18 /var/www/html/includes/exception/MWExceptionHandler.php(135): MWExceptionRenderer::output(Error, int)
#19 /var/www/html/includes/exception/MWExceptionHandler.php(239): MWExceptionHandler::report(Error)
#20 /var/www/html/includes/MediaWikiEntryPoint.php(222): MWExceptionHandler::handleException(Error, string)
#21 /var/www/html/includes/actions/ActionEntryPoint.php(83): MediaWiki\MediaWikiEntryPoint->handleTopLevelError(Error)
#22 /var/www/html/includes/MediaWikiEntryPoint.php(206): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError(Error)

- Calling newTitleFactory on SMW does not exist anymore
Comment thread src/Processors/Content/Save.php Outdated
Comment thread src/Processors/Content/Save.php

@wgevaert wgevaert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@JimmyvanDelft

Copy link
Copy Markdown
Collaborator Author

@Designburo Could you merge this at your earliest convenience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants