Skip to content

[RPC]: Fill 'result' field in Condition message - #2546

Merged
edriouk merged 6 commits into
mainfrom
RpcConditionResult
Jul 29, 2026
Merged

[RPC]: Fill 'result' field in Condition message#2546
edriouk merged 6 commits into
mainfrom
RpcConditionResult

Conversation

@edriouk

@edriouk edriouk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes

Changes

  • Upgrade used CMSIS-RPC to 0.0.12
  • fill result field in Condition struct
  • corresponding tests

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@edriouk
edriouk requested a review from brondani July 29, 2026 07:52
brondani
brondani previously approved these changes Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Test Results

  2 files   14 suites   14m 56s ⏱️
477 tests 477 ✅ 0 💤 0 ❌
954 runs  954 ✅ 0 💤 0 ❌

Results for commit 8243c70.

♻️ This comment has been updated with latest results.

Correct bug in condition collection
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.41%. Comparing base (2dfa33b) to head (8243c70).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2546      +/-   ##
==========================================
- Coverage   68.31%   65.41%   -2.91%     
==========================================
  Files         140      147       +7     
  Lines       26507    26814     +307     
  Branches    16021    16249     +228     
==========================================
- Hits        18109    17540     -569     
- Misses       6093     7069     +976     
+ Partials     2305     2205     -100     
Flag Coverage Δ
buildmgr-cov 79.87% <ø> (ø)
packchk-cov 69.81% <ø> (+0.06%) ⬆️
projmgr-cov 88.05% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrRpcServer.cpp 85.85% <100.00%> (+0.02%) ⬆️
tools/projmgr/src/ProjMgrWorker.cpp 87.55% <100.00%> (+0.07%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edriouk
edriouk merged commit 37a8a8e into main Jul 29, 2026
74 of 75 checks passed
@edriouk
edriouk deleted the RpcConditionResult branch July 29, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants