Skip to content

[svdconv] Generate position/mask macros for dim fields - #2545

Open
thorstendb-ARM wants to merge 5 commits into
mainfrom
fieldDimPosMask
Open

[svdconv] Generate position/mask macros for dim fields#2545
thorstendb-ARM wants to merge 5 commits into
mainfrom
fieldDimPosMask

Conversation

@thorstendb-ARM

Copy link
Copy Markdown
Contributor

Fixes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Fixes #2439

Signed-off-by: Thorsten de Buhr <thorsten.deBuhr@arm.com>

@grasci-arm grasci-arm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No serious correctness issues found in the patch. The new dim-field handling is covered by an integration test, and the changes appear narrowly scoped.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Test Results

 4 files   -    35  10 suites   - 111   0s ⏱️ - 15m 6s
30 tests  -   898  30 ✅  -   881  0 💤  - 17  0 ❌ ±0 
60 runs   - 1 935  60 ✅  - 1 884  0 💤  - 51  0 ❌ ±0 

Results for commit c9ffd4a. ± Comparison against base commit 7036c89.

This pull request removes 900 and adds 2 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
HeaderData ‑ CreateRegisterPosMaskHandlesDimensionVariants
SvdConvIntegTests ‑ CheckPosMaskDimFields

♻️ This comment has been updated with latest results.

Signed-off-by: Thorsten de Buhr <thorsten.deBuhr@arm.com>
Comment thread tools/svdconv/SVDGenerator/src/HeaderData_PosMask.cpp Fixed
Signed-off-by: Thorsten de Buhr <thorsten.deBuhr@arm.com>
@thorstendb-ARM
thorstendb-ARM requested a review from edriouk July 29, 2026 08:26
@edriouk

edriouk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

rename tools/svdconv/Test directory to tools/svdconv/test to avoid coverage problems

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.31%. Comparing base (7036c89) to head (c9ffd4a).

Files with missing lines Patch % Lines
...ls/svdconv/SVDGenerator/src/HeaderData_PosMask.cpp 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
+ Coverage   65.39%   68.31%   +2.92%     
==========================================
  Files         147      140       -7     
  Lines       26813    26507     -306     
  Branches    16248    16021     -227     
==========================================
+ Hits        17534    18109     +575     
+ Misses       7072     6093     -979     
- Partials     2207     2305      +98     
Flag Coverage Δ
svdconv-cov 46.82% <81.81%> (+6.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ls/svdconv/SVDGenerator/src/HeaderData_PosMask.cpp 52.25% <81.81%> (+52.25%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edriouk edriouk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants