Skip to content

Added Infineon_Device_Configurator and InfineonMcuConfigWizard - #2528

Open
OttJulia wants to merge 4 commits into
Open-CMSIS-Pack:mainfrom
OttJulia:patch-1
Open

Added Infineon_Device_Configurator and InfineonMcuConfigWizard#2528
OttJulia wants to merge 4 commits into
Open-CMSIS-Pack:mainfrom
OttJulia:patch-1

Conversation

@OttJulia

@OttJulia OttJulia commented Jul 20, 2026

Copy link
Copy Markdown

Added Infineon_Device_Configurator and InfineonMcuConfigWizard (MOTIX and LITIX devices)

Fixes

  • none

Changes

  • Added new generators

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@jkrech jkrech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) There already exists a global generator with ID InfineonDeviceConfigurator. You are adding a global generator ID Infineon_Device_Configurator using _ this can be easily overlooked and can cause user confusion.
The download-url is identical: https://softwaretools.infineon.com/tools/com.ifx.tb.tool.deviceconfigurator
However the run: node and the path: are different.
Is there a good reason why this cannot be unified?

b) The "run:" node specified a *.bat file which only executes on windows, specify a launch script without extension and then provide launch scripts with different launch scripts for each platform

  • darwin-arm-64 (bash)
  • linux-amd64 (bash)
  • linux-arm64 (bash)
  • windows-amd64 (bat)
  • windows-arm64 (bat)
    even if the invocation just prints: Platform is not supported for Infineon Device Configurator! and exit 1.
    The generator much not silently fail and leave the user puzzled.

c) The launch scripts need to be added via a PR in this repository:
https://github.com/Open-CMSIS-Pack/generator-bridge/tree/main/scripts
The existing Infineon script are here:
https://github.com/Open-CMSIS-Pack/generator-bridge/tree/main/scripts/Infineon_Device_Configurator

d) For the InfineonMcuConfigWizard scripts need to be added via a PR as well:
https://github.com/Open-CMSIS-Pack/generator-bridge/tree/main/scripts/InfineonMcuConfigWizard

@OttJulia

Copy link
Copy Markdown
Author

a) I see where the confusion comes from, especially because InfineonDeviceConfigurator uses a folder named Infineon_Device_Configurator in the bridge repo.
The reason for added the same tool as a new generator is that the path arguments are different. Two independent teams selected different file structures for their examples, and now they are like that and won't be changed. I was thinking about adding the differentiation based on device name to the batch, but that seemed not very safe for the future.
I could rename it to InfineonDeviceConfigurator_MotixLitix and integrate the device families in the generator name - what do you think?

b/c/d) Thanks, I will update the run element and add the scripts once the name is clarified

@jkrech

jkrech commented Jul 21, 2026

Copy link
Copy Markdown
Member

Thanks for sharing the background.
Your proposal for the global generator ID sounds sensible as it does make the ID unique.
I am unable to judge how familiar your end users are with MotixLitix but I assume this is fine.
The only concern is the length of the ID
Maybe InfineonDevConf_MotixLitix works for you as well.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

Test Results

  2 files   -    37   14 suites   - 107   13m 35s ⏱️ - 5m 3s
477 tests  -   451  477 ✅  - 434  0 💤  - 17  0 ❌ ±0 
954 runs   - 1 041  954 ✅  - 990  0 💤  - 51  0 ❌ ±0 

Results for commit 629a448. ± Comparison against base commit f512b38.

This pull request removes 451 tests.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

♻️ This comment has been updated with latest results.

removed bat file ending from generator scripts reference
@jkrech
jkrech requested review from brondani and jkrech July 21, 2026 09:46
@jkrech

jkrech commented Jul 21, 2026

Copy link
Copy Markdown
Member

@OttJulia, could you please create the PR for the launch scripts you are referencing
https://github.com/Open-CMSIS-Pack/generator-bridge/tree/main/scripts
We would merge both PRs for the same nightly build of the CMSIS-Toolbox.

@OttJulia

Copy link
Copy Markdown
Author

Created a PR for the generator files: Open-CMSIS-Pack/generator-bridge#355

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.39%. Comparing base (f512b38) to head (629a448).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files         147      147           
  Lines       26813    26813           
  Branches    16248    16248           
=======================================
  Hits        17534    17534           
  Misses       7072     7072           
  Partials     2207     2207           
Flag Coverage Δ
projmgr-cov 88.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani brondani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To package the scripts correctly in CMSIS-Toolbox, the following workflows and integration test also need to be extended in the cmsis-toolbox repository:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants