feat: put page chips on demo catalog Q&A - #310
Merged
Merged
Conversation
Seed answers now include [[cite:n]] next to the claims, and citation payloads copy page numbers and page-image URLs from the resolved chunk so Notebook can render {title}/pN.
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep GOOG, Meta earnings-call, and SpaceX demo artifacts as the API returned them. Citation chips pin a page on the original Root chunk instead of inventing per-page cards. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[cite:n]]next to claims in Tesla and SpaceX demo catalog answers.page_citation_page_number,page_nums, andpage_citation_asset_urlfrom the resolved chunk onto each demo citation.Notebook consumes these fields so seed chat matches live
{title}/pNchips. Pair with the Notebook follow-up PR.Test plan
uv run pytest tests/contract/test_demo_documents_contract.py::test_should_project_demo_example_cite_markers_and_page_numbersGET /api/v1/demo/catalogTesla xAI example includes[[cite:1]]andpage_citation_page_number: 12Made with Cursor