Skip to content

feat: page answer provenance highlights on displayed images - #148

Merged
EricNGOntos merged 2 commits into
stagingfrom
feat/wuchengke/page-answer-highlights
Aug 21, 2026
Merged

feat: page answer provenance highlights on displayed images#148
EricNGOntos merged 2 commits into
stagingfrom
feat/wuchengke/page-answer-highlights

Conversation

@EricNGOntos

Copy link
Copy Markdown
Contributor

Summary

  • Extend inspectImage to return normalized answer provenance boxes (multi-page, multi-region) and attach them to finalize-displayed image artifacts.
  • Render red translucent overlays on chat page images; keep original image layout when no highlights are present.
  • Soft-fail structured vision output: fall back through JSON text / analysis-only so inspect still succeeds when the model lacks native object generation.

Test plan

  • Focused unit tests: image-inspection-model, image-highlights, chat-message-list, route-service
  • Staging chat: page-mode question that triggers inspectImage + finalize display of the same page image
  • Confirm overlays appear only on displayed artifacts with matching refs
  • Confirm no-highlight image layout still uses object-contain
  • Confirm structured-output failure still returns analysis without breaking the turn

Made with Cursor

Extend inspectImage with structured bbox regions, persist them on finalize artifacts, and render red translucent overlays in chat. Fall back to analysis-only when structured vision output is unavailable.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview Aug 21, 2026 4:30am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Preview Aug 21, 2026 4:30am

Request Review

Import ImageInspectionHighlights, drop unsupported generateObject experimental_include, and complete HarnessTrace fixtures with imageHighlights.

Co-authored-by: Cursor <cursoragent@cursor.com>
@EricNGOntos
EricNGOntos merged commit 680d772 into staging Aug 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant