Skip to content

fix: open Official Library demo citations in parsed results - #147

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/demo-citation-library-select
Aug 20, 2026
Merged

fix: open Official Library demo citations in parsed results#147
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/demo-citation-library-select

Conversation

@suguanYang

Copy link
Copy Markdown
Contributor

Summary

  • Guest demo Tesla/SpaceX rows are Official Library sources, so citation clicks selected them and then immediately cleared selectedSourceId.
  • Keep an explicitly selected library demo source so the parsed panel jumps to the cited chunk instead of the empty "Log in to add documents" state.

Test plan

  • Open a guest demo workspace, click a Tesla or SpaceX seed citation chip
  • Parsed Results should show that document and focus the cited chunk, not the login empty state
  • pnpm exec vitest run src/components/workspace-source-state.test.ts src/components/workspace-shell.test.ts

Made with Cursor

Tesla and SpaceX seed citations point at catalog rows tagged as Official
Library. Resolving those ids back to null left the parsed panel on the
guest empty login state instead of the cited chunk.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview Aug 20, 2026 5:07pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Aug 20, 2026 5:07pm

Request Review

@suguanYang
suguanYang merged commit 3f61aa8 into staging Aug 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant