feat: archive remote Knowhere sources and filter by client origin - #146
Merged
Merged
Conversation
Remote-only sidebar ids now call Knowhere archive (and clean a matching local row if one exists). Listing and chat only show remotes created by notebook, CLI, or MCP. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Only drop singleton page cards that repeat the same page number. Multi-page section chunks that share a boundary page stay visible. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATCH /api/sources/knowhere-doc:…now archives the Knowhere document instead of 404ing; if a matching Notebooksourcesrow exists it is soft-deleted and its blob is cleaned up.listDocumentsonly show documents withcreated_by_client/createdByClientin{notebook, cli, mcp}. Untagged leftovers (e.g. stagingdummy.pdf) stay in Knowhere but no longer appear in the sidebar.Test plan
Made with Cursor