chore: bump knowhere-sdk to 2.2.0 for grep page numbers - #144
Merged
Conversation
Use the published KnowledgeGrepMatch.pageNumbers field instead of a type cast so citation chips can take page numbers from grep without a follow-up read. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ontos-ai/knowhere-sdkfrom^2.1.2to^2.2.0so Notebook gets publishedKnowledgeGrepMatch.pageNumbers./pNfrom grep without a follow-upreadChunksin the common case.This landed after PR 143 merged, so it is a follow-up on
staging.Test plan
pnpm exec tsc --noEmitpnpm exec vitest run src/agent-harness/ledger.test.ts src/domains/chat/index.test.ts{title}/pNwithout an extra chunk read when the match already has page numbersMade with Cursor