Release PHP 2.1.1 with canonical futures examples - #11
Conversation
|
Warning Review limit reached
Next review available in: 40 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe release updates the SDK to version 2.1.1, changes Brent futures examples to a generic route, detects fixed request-cadence claims, strengthens CI controls, updates smoke-install defaults, and expands regression tests. ChangesSDK release validation
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/PublicClaimsTest.php`:
- Around line 127-140: The test
testWorkflowActionsArePinnedAndCheckoutCredentialsAreNotPersisted currently
validates persist-credentials: false only via global counts; update it to
inspect every actions/checkout step and assert each checkout configuration
contains its own persist-credentials: false setting, while retaining the
existing pinned-action assertions.
- Around line 114-125: Update
testPackagedSurfacesUseInstrumentGenericFuturesPaths to scan all packaged text
surfaces rather than relying on publicSurfaceFiles(), including Markdown, JSON,
and extensionless customer files. Reuse the installed archive text-file list or
the discovery mechanism used by the package-claim scan, while preserving the
existing venue-specific route assertion and diagnostic message.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9b8e0b60-cdbd-49a7-ae33-0fa249b11604
📒 Files selected for processing (9)
.github/workflows/test.ymlCHANGELOG.mdREADME.mdscripts/clean-install-smoke.shscripts/validate-public-claims.phpsrc/Client.phpsrc/RawClient.phptests/ClientTest.phptests/PublicClaimsTest.php
Summary
Red-green evidence
vendor/bin/phpunit --testdox(25 tests, 303 assertions)composer validate --strictbash scripts/clean-install-smoke.sh(16 exact installed text surfaces; success plus missing config/401/403/429 recovery)/v1/futures/brent/curvereturned 14 contracts without exposing credentialsRelease contract
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores