ci: harden Sheets release workflows - #34
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflows disable persisted checkout credentials. GitHub Pages adds moderate-severity dependency auditing and updates deployment actions. The test suite parses all three hosted workflows and validates their security and deployment settings. ChangesWorkflow security and validation
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/public-claims.test.js`:
- Around line 147-172: Update the workflow assertions to inspect the expected
job rather than flattened steps for job-specific requirements. Require every
checkout and setup-node step to use the specified v6 and v6 actions, select the
appropriate validation job before asserting the npm audit command, and scope
GitHub Pages action checks to document.jobs.deploy.steps while asserting the
exact required action versions so legacy actions cannot pass.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: fb5dc6d3-1a3d-4697-a9cb-ef89063559ff
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
.github/workflows/apps-script-release.yml.github/workflows/github-pages.yml.github/workflows/validate.ymlpackage.jsontest/public-claims.test.js
Summary
Red-green proof
node --test test/public-claims.test.js-> 8 passed, 1 failed (persist-credentialsmissing)npm ci;npm audit --audit-level=moderate-> 0Production evidence
Current main Pages run 31495600126 is green but emits the GitHub Node 20 deprecation annotation for configure-pages@v4, deploy-pages@v4, and upload-artifact@v4 (via upload-pages-artifact@v3). The selected official releases are configure-pages@v6, upload-pages-artifact@v5, and deploy-pages@v5. A post-merge Pages run must be green with the annotation absent.
No Apps Script version, Marketplace draft, public listing, or runtime source is changed by this PR. Sheets v13 remains held for the explicit API v2 production-green signal.
Summary by CodeRabbit
Security
Reliability
Testing