orrery install: report the account and its workspace - #18
Merged
Conversation
The install success message now names both the target account and the workspace it is pinned to (e.g. 帳號「work」所在的 workspace「team」) — clarifying that shared add-ons (the statusline program) land in the workspace while the settings patch is per-account. Adds a claudeWorkspaceLabel helper (DRY'd with the account label) + a workspace param to L10n.Install.success across all locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orrery installnow names both the account and the workspace it's pinned to in its success message — making it clear that a shared add-on (the statusline program) lands in the workspace while thesettings.jsonpatch is per-account.Installed {id} (…) into account '{env}' in workspace '{workspace}'. …已將 {id}（…）安裝到帳號「{env}」所在的 workspace「{workspace}」，…Changes
claudeWorkspaceLabel(forEnv:)(reads the account'smetadata.jsonworkspace, absent ⇒ origin), DRY'd withclaudeAccountLabelvia a sharedclaudeAccountDirPath/claudeAccountMetadata.L10n.Install.successgains aworkspaceparameter (all 3 locales +l10n-signatures.json; codegen validates placeholder↔signature at build).orrery installonly (uninstall message unchanged).Test Plan
swift buildclean (L10n codegen accepts the new signature/placeholders).swift test --filter LocalizationTests— passes, incl. newtestInstallSuccessNamesAccountAndWorkspace(rendered message contains both account and workspace).