fix(sell): stop defaulting agent offer description to the internal objective#768
Merged
Merged
Conversation
…jective sell_agent.go silently defaulted an omitted --description to agent.Objective — free-text operator instructions that can contain wallet addresses and tool endpoints — and wrote it unconditionally into spec.registration.description, which is always published to the storefront catalog, skill.md, OpenAPI doc, and (when enabled) the ERC-8004 registration document, regardless of --no-register. Remove the fallback so an empty --description now falls through to the controller's existing safe generic default, matching sell http/sell mcp. Also fixes the Usage text that documented the leaky default and warns the operator when registration is enabled with no description set. Addresses a Canary402 field report. Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canary402 field report — issue 9 (⚠️ agent objectives leak into public descriptions)
obol sell agentdefaultedspec.registration.description— published to the storefront catalog, skill.md and registration documents, regardless of--no-register— to the entire internal Agent objective, potentially exposing tool addresses and operational instructions.Fix
The objective fallback is removed: an omitted
--descriptionnow falls through to the controller's existing safe generic defaults (same behavior assell http/sell mcp). The flag's usage text no longer documents the leaky default, and the CLI warns when registering without an explicit description. Description resolution is extracted into a small pure function so the non-propagation is directly unit-tested.go build ./... && go test ./cmd/obol/...green.Part of the Canary402 field-report sweep (6 PRs). Commit unsigned — batch re-sign before merge if required.
https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk