✨ Switch to Adventure ComponentLogger - #193
Open
Zoriot wants to merge 1 commit into
Open
Conversation
Implements: OakLoaf#187. BREAKING-CHANGE: Api now also uses ComponentLogger instead of java's Logger
OakLoaf
approved these changes
Aug 16, 2026
Owner
|
Thank you, this will be merged as part of version 5 |
Contributor
Author
|
What Else is planned for v5? Any Rough estimate about it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #187.
BREAKING-CHANGE: Api now also uses ComponentLogger instead of java's Logger
Where possible it uses the provided Logger, else creates an own one. Smaller changes are made to the format of log statements to log it correctly. E.g. use Logger formatting, interrupt InterruptedException.
CLI no uses SL4F Simple Logger. We could also use another logging framework, but this was the easiest to use.
Basic Tested on Paper, Velocity & Cli.
According to sem ver this would probably be v5? If I should bump it here lmk.
This also fixes delayed Log Messages.