fix: code quality - variable typo, dead import, PEP 8 identity checks, unnecessary f-strings

[BEAST04289]

Summary

Code quality fixes found during a full codebase audit. All changes are zero-behavior-change.

Follows up on leftover items from #836 / #837 (which was scoped down to just the get_by_tags shadowing fix during rebase).

Changes

Variable Typo Fix

• pentalty → penalty in gap_analysis.py (3 occurrences, lines 100–102) — misspelled local variable from get_path_score()

Dead Import Removal

• import json as _json removed from cre_main.py — imported but never referenced anywhere in the file (json is already imported on line 4)

PEP 8: == None → is None (6 occurrences across 5 files)

Per PEP 8: comparisons to singletons like None should use is / is not, because == invokes __eq__ which a custom class could override, while is checks object identity — and None is a singleton, so identity is the correct check.

Files: spreadsheet_parsers.py (×2), oscal_utils.py, export_format_parser.py, inmemory_graph.py, db.py

Unnecessary f-string Prefixes (production code only)

Removed f prefix from ~23 strings that contain no {} placeholders:

• web_main.py — 13 posthog event names + 1 logger call
• db.py — 4 exception/log messages
• cre_main.py — 4 logger calls
• prompt_client.py — 2 logger calls

Test files were intentionally left untouched to keep the diff focused.

Testing

• All 9 modified files compile cleanly (python -m py_compile)
• Verified via grep: zero remaining pentalty, _json, or == None in the codebase
• All changes are cosmetic/style only — zero behavior change

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

This PR modernizes None checks, corrects a gap-analysis penalty variable, removes unnecessary f-string prefixes from logging and exception messages, updates telemetry event literals, and adjusts Neo4j population logging.

Changes

Python cleanup and correctness updates

Layer / File(s)	Summary
Null checks and penalty scoring application/database/db.py, application/database/inmemory_graph.py, application/utils/{external_project_parsers,spreadsheet_parsers}.py, application/utils/gap_analysis.py, application/utils/oscal_utils.py	Null comparisons use is None, and gap-analysis scoring now references the correctly named penalty variable.
Population flow and telemetry strings application/cmd/cre_main.py, application/prompt_client/prompt_client.py, application/web/web_main.py	Neo4j progress messages, prompt-client logs, and PostHog event names use plain string literals; the private JSON import alias is removed.
Database message literals application/database/db.py	Database exception and error messages remove unnecessary f-string prefixes while preserving their text.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: manshusainishab, paoga87, northdpole, pa04rth

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 38.46% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main code-quality fixes in the change set.
Description check	✅ Passed	The description is clearly related and matches the implemented zero-behavior code-quality changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR aims to apply code-quality cleanups across the Python codebase (typo fix, PEP 8 None identity checks, and removal of unnecessary f-strings) while keeping behavior unchanged.

Changes:

• Rename misspelled local variable pentalty → penalty in gap analysis scoring.
• Replace == None checks with is None for PEP 8 singleton comparisons across multiple modules.
• Remove f prefixes from strings that have no interpolation, and remove a purportedly-dead JSON import alias.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
application/web/web_main.py	Removes unnecessary f-strings in PostHog event names and one logger call.
application/utils/spreadsheet_parsers.py	Replaces == None with is None in parsing logic.
application/utils/oscal_utils.py	Replaces uuid == None with uuid is None in OSCAL conversion.
application/utils/gap_analysis.py	Fixes local variable typo (pentalty → penalty) in path scoring.
application/utils/external_project_parsers/parsers/export_format_parser.py	Replaces == None with is None in export-format parsing.
application/prompt_client/prompt_client.py	Removes unnecessary f-strings from logger messages.
application/database/inmemory_graph.py	Replaces == None with is None for graph cache check.
application/database/db.py	Replaces == None with is None and removes unnecessary f-strings in exception/log strings.
application/cmd/cre_main.py	Removes f-strings and removes import json as _json (but _json is still referenced later).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.