Increase CMake minimum version from 3.16 to 3.22.1 - #4824
Draft
mwtoews wants to merge 2 commits into
Draft
Conversation
Contributor
|
What about upgrading Ubuntu already to 24.04? |
Member
Author
|
I'd prefer keeping the CI testing to use the minimum supported versions. Also, I might hold this on draft to separate the CI upgrade stuff separately.... see #4825 |
mwtoews
marked this pull request as draft
August 22, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the CMake minimum version from 3.16 to 3.22.1. It also cleans up code that was needed to support older CMake versions.
I will consider some improvements using
target_compile_features()(discussed in #1924) in a follow-up.Closes #4756