feat(trino): enable dynamic client registration - #31
Open
octavepre wants to merge 2 commits into
Open
Conversation
… is set and the ID provider is Keycloak
SteBaum
reviewed
Jul 21, 2026
| #tag: 480-p01 | ||
| # Currently, the UI requires the version to conform to SemVer (https://simversion.github.io/) | ||
| # https://github.com/OKDP/okdp-ui/blob/main/src/app/shared/utils/utils.ts#L131 | ||
| tag: 480.0.0-p04 |
There was a problem hiding this comment.
You will have to increase the package tag to 480.0.0-p06 if we take the PR #28 into account.
Contributor
Author
There was a problem hiding this comment.
I'm waiting for the previous PRs to be merged to bump the version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
5 new variables and 2 new packages are introduced in this release.
The first package,
oidc-dcr, allows clients to be dynamically registered with the ID Provider. This package then retrieves the client’s name, ID, secret, scopes, and issuer URL, and saves them in a secret.oidc-dcrcan be enabled or disabled using theenableDCRvariable. The scopes are passed as parameters and can be modified by the user when creating the Trino instance on the OKDP UI.The second package,
keycloak-config-cli, allows you to add theclient-scopegroupsto the new client created just before. This package has two prerequisites for execution: the ecosystem must use Keycloak as the identity provider, and theenable DCRvariable must be set totrue. Additionally, this package depends on theoidc-dcrpackage, which means it waits foroidc-dcrto finish running before starting.keycloak-config-cliuses the Keycloak admin profile to modify certain settings. It requires two variables to run:keycloakAdminUserandkeycloakAdminPassword.Trino’s
mainpackage has been modified. Depending on the value of theenableDCRvariable, the variables related to the Trino client will differ. If disabled, the variables will remain the same as before this feature was created. If enabled, the variables will take on the values contained in a secret previously created when theoidc-dcrpackage was executed.Related Issue
Fixes #29
Depends on #30
Type of Change
DCR allows a client to be registered directly within the ID provider in a dynamic and secure manner, without having to store any secrets in the codebase.
How to Test
Create a Trino instance on OKDP UI.
The client is automatically created in the ID Provider.
Checklist