[18.0][IMP] hr_shift: prevent overlapping shift planning lines for the same… - #48
Open
cvinh wants to merge 1 commit into
Open
[18.0][IMP] hr_shift: prevent overlapping shift planning lines for the same…#48cvinh wants to merge 1 commit into
cvinh wants to merge 1 commit into
Conversation
… employee hr.shift.planning.line has no constraint that prevents two lines from sharing time with each other for the same employee. Two lines can be created for the same weekday with overlapping start_time/end_time ranges (for example after a manual drag/resize on the calendar view, or by adding a second line whose template overlaps an existing one), which puts the employee in two shifts at the same instant. Add a constraint on hr.shift.planning.line that rejects such overlaps, applied only between assigned lines of the same employee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… employee
hr.shift.planning.line has no constraint that prevents two lines from sharing time with each other for the same employee. Two lines can be created for the same weekday with overlapping start_time/end_time ranges (for example after a manual drag/resize on the calendar view, or by adding a second line whose template overlaps an existing one), which puts the employee in two shifts at the same instant.
Add a constraint on hr.shift.planning.line that rejects such overlaps, applied only between assigned lines of the same employee.