Skip to content

[18.0][IMP] hr_shift: add day in shift planning line calendar view - #43

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
invitu:18.0-imp_hr_shift_calendar_view_day
Jul 22, 2026
Merged

[18.0][IMP] hr_shift: add day in shift planning line calendar view#43
OCA-git-bot merged 1 commit into
OCA:18.0from
invitu:18.0-imp_hr_shift_calendar_view_day

Conversation

@cvinh

@cvinh cvinh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

easy improvement

@cvinh
cvinh force-pushed the 18.0-imp_hr_shift_calendar_view_day branch from ef4dbbb to 6a7db15 Compare July 22, 2026 00:48
@cvinh
cvinh force-pushed the 18.0-imp_hr_shift_calendar_view_day branch from 6a7db15 to 044c15d Compare July 22, 2026 00:50
@pedrobaeza pedrobaeza added this to the 18.0 milestone Jul 22, 2026
@pedrobaeza

pedrobaeza commented Jul 22, 2026

Copy link
Copy Markdown
Member

I don't see the advantage of this, as the week view shows the same time slots. It's only the horizontal space.

@cvinh

cvinh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

I don't see the advantage of this, as the week view shows the same time slots. It's only the horizontal space.

Thanks for feedback... sorry not to have explained this one...
our use case is a small company with 10 employees, the week view is not accurate because we only see sharp vertical lines... in day view we can see better...
BTW you will see a few other PRs linked to our customer case... I hope we manage to explain well

pedrobaeza
pedrobaeza approved these changes Jul 22, 2026
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, still not understanding, but being something optional, let's not question it.

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-43-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 2c32a2f into OCA:18.0 Jul 22, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7fe0445. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Jul 22, 2026
Open
@cvinh
cvinh deleted the 18.0-imp_hr_shift_calendar_view_day branch July 22, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
+1 more reviewer
@victoralmau victoralmau victoralmau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:hr_shift Module hr_shift series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cvinh @pedrobaeza @OCA-git-bot @victoralmau