[18.0][IMP] hr_shift: allow regenerate_shifts on a multi-record selection - #41
Merged
OCA-git-bot merged 1 commit intoJul 23, 2026
Merged
Conversation
cvinh
force-pushed
the
18.0-imp_hr_shift_add_multirecord_action
branch
from
July 20, 2026 17:07
118bf45 to
c09f800
Compare
victoralmau
approved these changes
Jul 21, 2026
pedrobaeza
requested changes
Jul 22, 2026
| self.state = "assignment" | ||
|
|
||
| def regenerate_shifts(self): | ||
| self.shift_ids.unlink() |
Member
There was a problem hiding this comment.
This one is already multi-record aware.
| self.assertEqual(shift_b_line_1.state, "assigned") | ||
| self.assertEqual(shift_b_line_1.template_id, self.template_afternoon) | ||
|
|
||
| def test_hr_shift_regenerate_shifts_multi(self): |
Member
There was a problem hiding this comment.
This test is not adding value.
cvinh
force-pushed
the
18.0-imp_hr_shift_add_multirecord_action
branch
from
July 22, 2026 18:42
c09f800 to
d7a735d
Compare
Contributor
Author
|
no more codecov ? |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 5da4f90. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.